Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removing finalizers and controllerswitch #3779

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JaydipGabani
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #3084

Special notes for your reviewer:

@JaydipGabani JaydipGabani requested a review from a team as a code owner January 15, 2025 00:51
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 47.70%. Comparing base (3350319) to head (42d5cde).
Report is 231 commits behind head on master.

Files with missing lines Patch % Lines
pkg/controller/config/config_controller.go 50.00% 1 Missing ⚠️
pkg/controller/constraint/constraint_controller.go 0.00% 1 Missing ⚠️
...onstrainttemplate/constrainttemplate_controller.go 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3779      +/-   ##
==========================================
- Coverage   54.49%   47.70%   -6.79%     
==========================================
  Files         134      235     +101     
  Lines       12329    19852    +7523     
==========================================
+ Hits         6719     9471    +2752     
- Misses       5116     9490    +4374     
- Partials      494      891     +397     
Flag Coverage Δ
unittests 47.70% <83.33%> (-6.79%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaydipGabani JaydipGabani requested a review from ritazh January 15, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove RBAC for finalizers from manifest
3 participants